Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emqx_channel): return Receive-Maximum in CONNACK when no error #12492

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Feb 8, 2024

Fixes #3648 and EMQX-11820

Release version: v/e5.6.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone marked this pull request as ready for review February 9, 2024 09:44
@zmstone zmstone requested review from lafirest and a team as code owners February 9, 2024 09:44
@zmstone zmstone merged commit cbebc59 into emqx:master Feb 9, 2024
165 checks passed
@zmstone zmstone deleted the 0208-fix-return-receive-maximum-in-connack branch February 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set ReceiveMaximum properties in CONNACK?
3 participants