Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0217 improve frame too large logging context #12530

Merged
merged 4 commits into from Feb 19, 2024
Merged

0217 improve frame too large logging context #12530

merged 4 commits into from Feb 19, 2024

Commits on Feb 18, 2024

  1. feat(mqtt): add more logging context for frame_too_large error

    @zmstone
    zmstone committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    22dabcb View commit details
    Browse the repository at this point in the history

  2. test: for better test coverage

    @zmstone
    zmstone committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    668d3be View commit details
    Browse the repository at this point in the history

  3. docs: add changelog for PR 12530

    @zmstone
    zmstone committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    29c5c37 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. refactor: rename 'hint' to 'cause' for MQTT fram parse failure reason 

    'reason' is maybe the wrapping field's name, so it was not used.
'hint' however, per our logging convention, is usually a free text
description for human to read.
change to 'cause' here because the field is always an atom and
it's use as shutdown counter in esockd_connection_sup
    @zmstone
    zmstone committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8b0e15e View commit details
    Browse the repository at this point in the history