Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast if node host is not IP address but cluster strategy is dns with a or aaaa record type #12541

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Feb 20, 2024

Fixes #12484

Release version: v/e5.6.0

Summary

Added a schema validation to fail fast if the host part of node name is not IP but cluster strategy is dns with a or aaaa record type.

Example log:

2024-02-20T16:07:47.733469+01:00 [error] #{reason => integrity_validation_failure,result => #{domain => "local.host",explain => "Node name must be of name@IP format for DNS cluster discovery strategy with 'a' record type."},kind => validation_error,validation_name => check_node_name_and_discovery_strategy}

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested a review from a team as a code owner February 20, 2024 14:03
@zmstone zmstone force-pushed the 0220-fail-fqdn-node-name-if-dns-discovery branch 3 times, most recently from c63f326 to 35662c2 Compare February 20, 2024 15:07
@zmstone zmstone changed the title Fail fast if node host is not IP address but cluster strategy is dns Fail fast if node host is not IP address but cluster strategy is dns a or aaaa Feb 20, 2024
@zmstone zmstone changed the title Fail fast if node host is not IP address but cluster strategy is dns a or aaaa Fail fast if node host is not IP address but cluster strategy is dns with a or aaaa record type Feb 20, 2024
If cluster strategy is configured as `dns`, the node name
must be IP address
@zmstone zmstone force-pushed the 0220-fail-fqdn-node-name-if-dns-discovery branch from 35662c2 to dc015e7 Compare February 20, 2024 15:09
@zmstone zmstone merged commit 1de9e9d into emqx:master Feb 20, 2024
166 checks passed
@zmstone zmstone deleted the 0220-fail-fqdn-node-name-if-dns-discovery branch February 20, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes can't communicate in static cluster
2 participants