New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor DynamoDB bridge to connector and action #12543
Merged
kjellwinblad
merged 4 commits into
emqx:master
from
kjellwinblad:kjell/refactor/dynamodb/EMQX-11456
Feb 22, 2024
Merged
feat: refactor DynamoDB bridge to connector and action #12543
kjellwinblad
merged 4 commits into
emqx:master
from
kjellwinblad:kjell/refactor/dynamodb/EMQX-11456
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellwinblad
force-pushed
the
kjell/refactor/dynamodb/EMQX-11456
branch
2 times, most recently
from
February 21, 2024 13:17
7f4d704
to
2b2e4b7
Compare
kjellwinblad
force-pushed
the
kjell/refactor/dynamodb/EMQX-11456
branch
2 times, most recently
from
February 21, 2024 13:40
70ea008
to
d6f188a
Compare
thalesmg
previously approved these changes
Feb 21, 2024
@@ -1,4 +1,4 @@ | |||
%%-------------------------------------------------------------------- | |||
%%--------------------------------------------------------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nano nit: revert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in first commit and force pushed
kjellwinblad
force-pushed
the
kjell/refactor/dynamodb/EMQX-11456
branch
from
February 21, 2024 13:56
d6f188a
to
4678df2
Compare
thalesmg
previously approved these changes
Feb 21, 2024
The CI check ./scripts/apps-version-check.sh requires that emqx_bridge_gcp_pubsub's version number is bumped.
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
thalesmg
approved these changes
Feb 21, 2024
zhongwencool
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://emqx.atlassian.net/browse/EMQX-11456
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md
files