Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor DynamoDB bridge to connector and action #12543

Merged

Conversation

kjellwinblad
Copy link
Contributor

@kjellwinblad kjellwinblad commented Feb 20, 2024

Fixes:
https://emqx.atlassian.net/browse/EMQX-11456

Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • [] Added property-based tests for code which performs user input validation
  • [] Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

@kjellwinblad kjellwinblad force-pushed the kjell/refactor/dynamodb/EMQX-11456 branch 2 times, most recently from 7f4d704 to 2b2e4b7 Compare February 21, 2024 13:17
@kjellwinblad kjellwinblad marked this pull request as ready for review February 21, 2024 13:21
@kjellwinblad kjellwinblad requested review from JimMoen and a team as code owners February 21, 2024 13:21
@kjellwinblad kjellwinblad force-pushed the kjell/refactor/dynamodb/EMQX-11456 branch 2 times, most recently from 70ea008 to d6f188a Compare February 21, 2024 13:40
thalesmg
thalesmg previously approved these changes Feb 21, 2024
@@ -1,4 +1,4 @@
%%--------------------------------------------------------------------
%%---------------------------------------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nano nit: revert?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in first commit and force pushed

thalesmg
thalesmg previously approved these changes Feb 21, 2024
kjellwinblad and others added 4 commits February 21, 2024 14:58
The CI check ./scripts/apps-version-check.sh requires that
emqx_bridge_gcp_pubsub's version number is bumped.
Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
@kjellwinblad kjellwinblad merged commit 7bb9d5d into emqx:master Feb 22, 2024
166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants