Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gcp_pubsub_bridges): make service account json a binary #12577

Merged
merged 1 commit into from Feb 27, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Feb 23, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-11384

Today, service_account_json config field is an embedded object (map()).

This requires user to embed a JSON object into the config file instead of embedding it as a string.

We should support binary() type as input, but keep supporting map() for backward compatibility.

Release version: v/e5.6

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the gcp-service-json-binary-m-20240223 branch 2 times, most recently from 49c1d1a to a6ddbc5 Compare February 23, 2024 18:53
Fixes https://emqx.atlassian.net/browse/EMQX-11384

Today, service_account_json config field is an embedded object (map()).

This requires user to embed a JSON object into the config file instead of embedding it as
a string.

We should support binary() type as input, but keep supporting map() for backward
compatibility.
@thalesmg thalesmg force-pushed the gcp-service-json-binary-m-20240223 branch from a6ddbc5 to f2c372d Compare February 26, 2024 12:21
@thalesmg thalesmg marked this pull request as ready for review February 26, 2024 14:04
@thalesmg thalesmg requested a review from a team as a code owner February 26, 2024 14:04
@thalesmg thalesmg merged commit 787dcd0 into emqx:master Feb 27, 2024
166 checks passed
@thalesmg thalesmg deleted the gcp-service-json-binary-m-20240223 branch February 27, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants