Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate kafka consumer bridge to source + connector #12595

Merged
merged 4 commits into from Mar 1, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Feb 26, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-11848

Release version: e5.6

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the kafka-consumer-source-m-20240223 branch 3 times, most recently from 8a49e4f to 4feb28c Compare February 26, 2024 20:00
@@ -775,7 +775,7 @@ handle_update(ConfRootKey, Id, Conf0) ->
Id,
case emqx_bridge_v2:lookup(ConfRootKey, BridgeType, BridgeName) of
{ok, _} ->
RawConf = emqx:get_raw_config([bridges, BridgeType, BridgeName], #{}),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@thalesmg thalesmg force-pushed the kafka-consumer-source-m-20240223 branch 2 times, most recently from 4bcafb4 to 37a43f0 Compare February 26, 2024 20:13
@@ -205,7 +207,11 @@ bridge_configs_to_transform(
emqx_utils_maps:deep_get(
[<<"actions">>, to_bin(BridgeType), to_bin(BridgeName)],
RawConfig,
undefined
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this: #12486 (comment)

@thalesmg thalesmg force-pushed the kafka-consumer-source-m-20240223 branch 2 times, most recently from a6cf725 to dd82eac Compare February 26, 2024 21:19
@thalesmg thalesmg marked this pull request as ready for review February 27, 2024 13:52
@thalesmg thalesmg requested review from JimMoen and a team as code owners February 27, 2024 13:52
@thalesmg thalesmg force-pushed the kafka-consumer-source-m-20240223 branch 4 times, most recently from 4c7c5d6 to 116f87f Compare February 27, 2024 20:51
@thalesmg thalesmg force-pushed the kafka-consumer-source-m-20240223 branch from 116f87f to 6b9844a Compare February 27, 2024 20:52
@zhongwencool zhongwencool merged commit d56fb22 into emqx:master Mar 1, 2024
166 checks passed
@thalesmg thalesmg deleted the kafka-consumer-source-m-20240223 branch March 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants