New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(prom): api crash when tls cert file non existed #12606
Merged
JimMoen
merged 5 commits into
emqx:release-55
from
JimMoen:EMQX-11914/fix-prom-api-crash
Feb 28, 2024
Merged
fix(prom): api crash when tls cert file non existed #12606
JimMoen
merged 5 commits into
emqx:release-55
from
JimMoen:EMQX-11914/fix-prom-api-crash
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Feb 28, 2024
zmstone
reviewed
Feb 28, 2024
JimMoen
force-pushed
the
EMQX-11914/fix-prom-api-crash
branch
from
February 28, 2024 06:53
761a661
to
5f12504
Compare
zmstone
reviewed
Feb 28, 2024
zmstone
reviewed
Feb 28, 2024
zmstone
reviewed
Feb 28, 2024
JimMoen
force-pushed
the
EMQX-11914/fix-prom-api-crash
branch
from
February 28, 2024 07:40
ee4e8bb
to
6fd04e3
Compare
zmstone
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-11914
Fixes #12603
The prom data of
emqx_cert_expiry_at
will be0
for non-existed cert.Release version: v/e5.5.1
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update