Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to hocon 0.42.0 #12634

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Mar 4, 2024

Release version: v/e5.6.0

Summary

This is a breaking fix:
backslashes in triple-quote strings are values, but not escape sequence.
This change is considered to have limited impact because:

  • EMQX 5.6 will be the first version to generate triple-quotes in cluster.hocon.
  • Escaping in triple-quote strings were only needed for backslash itself.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested review from lafirest and a team as code owners March 4, 2024 10:20
@zmstone zmstone force-pushed the 0304-breaking-no-escape-for-triple-quote-string-characters branch from 712daf2 to ef8f351 Compare March 4, 2024 11:01
ieQu1
ieQu1 previously approved these changes Mar 4, 2024
qzhuyan
qzhuyan previously approved these changes Mar 4, 2024
thalesmg
thalesmg previously approved these changes Mar 4, 2024
changes/ce/breaking-12634.en.md Outdated Show resolved Hide resolved
changes/ce/breaking-12634.en.md Outdated Show resolved Hide resolved
changes/ce/breaking-12634.en.md Outdated Show resolved Hide resolved
changes/ce/breaking-12634.en.md Outdated Show resolved Hide resolved
@zmstone zmstone dismissed stale reviews from thalesmg, qzhuyan, and ieQu1 via 6fb18b3 March 4, 2024 18:04
@zmstone zmstone force-pushed the 0304-breaking-no-escape-for-triple-quote-string-characters branch from ef8f351 to 6fb18b3 Compare March 4, 2024 18:04
@zmstone
Copy link
Member Author

zmstone commented Mar 4, 2024

@thalesmg thank you, fixed the typos.

thalesmg
thalesmg previously approved these changes Mar 4, 2024
changes/ce/breaking-12634.en.md Outdated Show resolved Hide resolved
@zmstone zmstone force-pushed the 0304-breaking-no-escape-for-triple-quote-string-characters branch from 6fb18b3 to 3e3194f Compare March 4, 2024 18:12
@zmstone zmstone merged commit 00b21cf into emqx:release-56 Mar 5, 2024
164 of 165 checks passed
@zmstone zmstone deleted the 0304-breaking-no-escape-for-triple-quote-string-characters branch March 5, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants