fix(vm): cpu usage/idle handled by single worker #12663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimMoen
changed the title
JimMoen
force-pushed
the
EMQX-11897/fix-cpu-usage/api
branch
from
8c871e1
to
230c491
Compare
thalesmg
reviewed
Mar 8, 2024
JimMoen
force-pushed
the
EMQX-11897/fix-cpu-usage/api
branch
from
230c491
to
b42922b
Compare
qzhuyan
reviewed
Mar 11, 2024
| @@ -131,7 +132,7 @@ handle_info({timeout, _Timer, mem_check}, #{sysmem_high_watermark := HWM} = Stat | |||
| handle_info({timeout, _Timer, cpu_check}, State) -> | |||
| CPUHighWatermark = emqx:get_config([sysmon, os, cpu_high_watermark]) * 100, | |||
| CPULowWatermark = emqx:get_config([sysmon, os, cpu_low_watermark]) * 100, | |||
| CPUVal = emqx_vm:cpu_util(), | |||
| CPUVal = cpu_sup:util(), | |||
There was a problem hiding this comment.
why this change? for accuracy?
There was a problem hiding this comment.
cpu_sup:util/0 will be called in single gen_server emqx_os_mon, no need to warp it in emqx_cpu_sup_worker process.
qzhuyan
previously approved these changes
Mar 11, 2024
JimMoen
force-pushed
the
EMQX-11897/fix-cpu-usage/api
branch
from
b42922b
to
0edeff4
Compare
thalesmg
approved these changes
Mar 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-11897
Release version: v/e5.6.0
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
[ ] If changed package build workflow, pass this action (manual trigger)[ ] Change log has been added tochanges/dir for user-facing artifacts update