Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): field shared_subscriptions in endpoint /monitor_current #12670

Merged

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Mar 8, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-11994

Release version: v/e5.6.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [ ] If changed package build workflow, pass this action (manual trigger)
  • [ ] Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen requested review from lafirest and a team as code owners March 8, 2024 10:21
@JimMoen JimMoen changed the title Feat shared sub count monitor current feat(api): field shared_subscriptions in endpoint /monitor_current Mar 11, 2024
@JimMoen JimMoen force-pushed the feat-shared-sub-count-monitor-current branch from 1dca18e to e5b818e Compare March 11, 2024 09:45
@JimMoen JimMoen merged commit d723a5e into emqx:release-56 Mar 13, 2024
166 checks passed
@JimMoen JimMoen deleted the feat-shared-sub-count-monitor-current branch March 13, 2024 10:26
HJianBo added a commit that referenced this pull request Mar 18, 2024
0315 Fix `shared_subscriptions` counting error. followup #12670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants