Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redact secrets from RocketMQ debug log #12681

Conversation

kjellwinblad
Copy link
Contributor

@kjellwinblad kjellwinblad commented Mar 12, 2024

Fixes:
https://emqx.atlassian.net/browse/EMQX-11987
Release version: v/e5.?

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • [] Added tests for the changes
  • [] Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [] Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • [] Schema changes are backward compatible

@kjellwinblad kjellwinblad requested a review from a team as a code owner March 12, 2024 09:02
@kjellwinblad kjellwinblad force-pushed the kjell/rocketmq_conn/remove_secret_from_logs/EMQX-11987 branch from 034628d to f502ba8 Compare March 12, 2024 09:29
@kjellwinblad kjellwinblad changed the base branch from master to release-56 March 12, 2024 09:29
@kjellwinblad kjellwinblad merged commit 9d99992 into emqx:release-56 Mar 13, 2024
166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants