Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridges): fix default value for enable when attempting operations #12696

Merged
merged 1 commit into from Mar 14, 2024

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Mar 13, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-11999

Although the frontend doesn't send enable when creating a bridge/action/connector, the default value in the schema is true, so when attempting to fetch it from the raw config we should adhere to that default.

Release version: v/e5.6

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

Fixes https://emqx.atlassian.net/browse/EMQX-11999

Although the frontend doesn't send `enable` when creating a bridge/action/connector, the
default value in the schema is `true`, so when attempting to fetch it from the raw config
we should adhere to that default.
@thalesmg thalesmg force-pushed the fix-default-enable-r56-20240313 branch from 2214e7a to b587eba Compare March 13, 2024 14:25
@thalesmg thalesmg marked this pull request as ready for review March 13, 2024 16:05
@thalesmg thalesmg requested review from JimMoen and a team as code owners March 13, 2024 16:05
@thalesmg thalesmg merged commit e340ab7 into emqx:release-56 Mar 14, 2024
166 checks passed
@thalesmg thalesmg deleted the fix-default-enable-r56-20240313 branch March 14, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants