Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cant replace source conf #12715

Merged
merged 1 commit into from Mar 19, 2024
Merged

fix: cant replace source conf #12715

merged 1 commit into from Mar 19, 2024

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Mar 15, 2024 •
edited

Fixes https://emqx.atlassian.net/browse/EMQX-12016 and https://emqx.atlassian.net/browse/EMQX-12019

Release version: v/e5.6.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool marked this pull request as ready for review March 15, 2024 09:48
@zhongwencool zhongwencool requested review from JimMoen and a team as code owners March 15, 2024 09:48
HJianBo
HJianBo previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@HJianBo HJianBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongwencool zhongwencool force-pushed the fix-source-replace-error branch 6 times, most recently from 3a8652c to 62aa635 Compare March 19, 2024 10:16
@HJianBo HJianBo merged commit 24c04e7 into emqx:release-56 Mar 19, 2024
166 checks passed
@zhongwencool zhongwencool deleted the fix-source-replace-error branch March 20, 2024 02:11
@BrewTestBot BrewTestBot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo approved these changes

@JimMoen JimMoen Awaiting requested review from JimMoen JimMoen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhongwencool @HJianBo