feat(ds): make durable sessions handle will messages #12742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieQu1
reviewed
Mar 19, 2024
apps/emqx/integration_test/emqx_persistent_session_ds_SUITE.erl
Outdated
Show resolved
Hide resolved
ieQu1
reviewed
Mar 19, 2024
apps/emqx_eviction_agent/src/proto/emqx_eviction_agent_proto_v3.erl
Outdated
Show resolved
Hide resolved
ieQu1
reviewed
Mar 19, 2024
thalesmg
force-pushed
the
ds-will-msg-m-20240318
branch
3 times, most recently
from
f7f847d
to
9c227b0
Compare
ieQu1
reviewed
Mar 20, 2024
thalesmg
force-pushed
the
ds-will-msg-m-20240318
branch
12 times, most recently
from
4a7c513
to
6a05968
Compare
thalesmg
force-pushed
the
ds-will-msg-m-20240318
branch
from
6a05968
to
0d30699
Compare
thalesmg
commented
Mar 25, 2024
|
|
||
| -spec set_will_message(emqx_maybe:t(message()), t()) -> t(). | ||
| set_will_message(Val, Rec) -> | ||
| set_meta(?will_message, Val, Rec). |
There was a problem hiding this comment.
Keeping the will message inside the ?meta table/domain will make things harder for the "session data in DS" feature, because of the lack of transactions there: we'd need to read the metadata and write it back, having the potential of races.
How about we have a table just for that, so that it maps to a topic (in the other PR) that can be safely overwritten without having to read it first?
ieQu1
approved these changes
Mar 25, 2024
ieQu1
previously approved these changes
Mar 25, 2024
thalesmg
force-pushed
the
ds-will-msg-m-20240318
branch
from
0d30699
to
0f426e6
Compare
ieQu1
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-10431
Release version: v/e5.7
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update