Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka_producer): handle ancient v1 config when migrating to actions #12767

Merged

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Mar 22, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-12064

Release version: e5.6

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg force-pushed the fix-older-kafka-migration-r56-20240322 branch from 98fab8a to bc5775a Compare March 22, 2024 12:45
@thalesmg thalesmg marked this pull request as ready for review March 22, 2024 13:45
@thalesmg thalesmg requested a review from a team as a code owner March 22, 2024 13:45
@thalesmg thalesmg merged commit 1218176 into emqx:release-56 Mar 22, 2024
166 checks passed
@thalesmg thalesmg deleted the fix-older-kafka-migration-r56-20240322 branch March 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants