Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade http client libs gun-1.3.11 and ehttpc-0.4.13 #12773

Merged
merged 2 commits into from Mar 25, 2024

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Mar 23, 2024

Fixes EMQX-12073

Release version: v/e5.7.0

Summary

HTTP client used in EMQX (gun-1.3) adds :portnumber suffix to the Host header even when the port numbers are standard (i.e. 80 for http and 443 for https).

This might cause some issues for certain servers. For example AWS Lambda and a similar alicloud service’s http gateway performs a strict check on the Host header sent from the clients.
The server or gateway may not be smart enough to strip aways the port number and return error messages like below

InvalidCustomDomain.NotFound
and “The specified CustomDomain does not exist."

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested a review from a team as a code owner March 23, 2024 09:34
@zmstone zmstone merged commit c8cb03f into emqx:master Mar 25, 2024
167 checks passed
@zmstone zmstone deleted the 0323-upgrade-http-clients branch March 25, 2024 16:29
@zmstone zmstone restored the 0323-upgrade-http-clients branch March 28, 2024 12:16
@zmstone zmstone deleted the 0323-upgrade-http-clients branch March 28, 2024 12:21
@emqxqa
Copy link

emqxqa commented May 8, 2024

Test Execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants