fix(emqx_mgmt): catch OOM shutdown exits properly when calling a conn procces #12814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt conn process
The exit reason is expected to include gen_server `Location`:
`{{shutdown, OOMInfo}, Location}`.
zmstone
reviewed
Mar 29, 2024
| @@ -0,0 +1,4 @@ | |||
| Handle several errors in `/clients/{clientid}/mqueue_messages` and `/clients/{clientid}/inflight_messages` APIs: | |||
|
|
|||
| - Internal timeout, which means that EMQX failed to get the list of Inflight/Mqueue messages within the default timeout of 5 s. This error may occur when the system is under a heavy load. The API will return 500 `{"code":"INTERNAL_ERROR","message":"timeout"}` response and log additional details. | |||
There was a problem hiding this comment.
Could be that the client process is stuck. Maybe even worth logging the current stacktrace from process_info
There was a problem hiding this comment.
Added a client proc stacktrace to the log event.
SergeTupchiy
force-pushed
the
EMQX-12124-fix-msgs-api-client-shutdown
branch
from
898895a
to
6cdf876
Compare
thalesmg
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Location:{{shutdown, OOMInfo}, Location}.Fixes EMQX-12124
Release version: v/e5.6.1
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update