Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client_attr): allow more than one initial extraction #12857

Closed

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Apr 10, 2024

Fixes EMQX-11882

Release version: v/e5.7.0

Summary

A follow up change for this comment: #12750 (comment)

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • [~] Schema changes are backward compatible (the change base is not released yet)

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 0410-support-multiple-client_attrs-init branch from aaeda4a to b6f4105 Compare April 11, 2024 10:48
@zmstone zmstone marked this pull request as ready for review April 11, 2024 11:26
@zmstone zmstone requested review from JimMoen, a team and lafirest as code owners April 11, 2024 11:26
@zmstone
Copy link
Member Author

zmstone commented Apr 12, 2024

will change to only use variform, drop regexp.

@zmstone zmstone closed this Apr 12, 2024
@savonarola
Copy link
Contributor

Sorry if stupid question, but what is variform? 😅

@zmstone
Copy link
Member Author

zmstone commented Apr 14, 2024

Sorry if stupid question, but what is variform? 😅

It's not a word, it's a term created in this PR: #12851

@zmstone
Copy link
Member Author

zmstone commented Apr 14, 2024

moved to this: #12872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants