feat(emqx_trace): add JSON trace log entry formatter #12863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Apr 16, 2024
zmstone
reviewed
Apr 16, 2024
This commit makes it possible to select the JSON trace log entry formatter when crating a trace pattern. This will make it easier for the dashboard and automatic tests to parse the log entries. Fixes: EMQX-12025 (partly)
kjellwinblad
force-pushed
the
kjell/new_trace_log_formatter/EMQX-12025
branch
from
1188df9
to
10957e7
Compare
kjellwinblad
force-pushed
the
kjell/new_trace_log_formatter/EMQX-12025
branch
from
53c142c
to
3232ab5
Compare
We wrap the reset of the process trace meta data in the after clause of a try-after-end expression to be sure we never get any lingering incorrect meta data.
kjellwinblad
force-pushed
the
kjell/new_trace_log_formatter/EMQX-12025
branch
from
67fbd9e
to
f5b0439
Compare
This commit removes some redundant trace messages and renames some to make it easier to interpret what is happening for the user.
zmstone
reviewed
Apr 19, 2024
zmstone
previously approved these changes
Apr 19, 2024
This commit removes the internal extra field from the trace config structure exposed to the user via the HTTP API.
zmstone
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to select the JSON trace log entry formatter when crating a trace pattern. This will make it easier for the dashboard and automatic tests to parse the log entries.
Fixes: EMQX-12025 (partly)
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles