Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qlc could not create temp files in docker container (#12875) #12885

Merged
merged 2 commits into from Apr 16, 2024

Conversation

id
Copy link
Collaborator

@id id commented Apr 16, 2024

Fixes #12875

qlc uses file_sorter that puts temporary files in the working directory by default, which is not writable by emqx user since 58d0f04.

One of the consequences is that users cannot access retained messages from the dashboard, but there are likely other issues as well.

This patch fixes this by making /opt/emqx directory owned by emqx:emqx.

Release version: v/e5.6.1

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@id id force-pushed the 0416-docker-chown-workdir branch from 4c65c0b to 24dd9c2 Compare April 16, 2024 05:59
@id id marked this pull request as ready for review April 16, 2024 06:01
@id id requested review from Rory-Z and a team as code owners April 16, 2024 06:01
Rory-Z
Rory-Z previously approved these changes Apr 16, 2024
id added 2 commits April 16, 2024 08:28
qlc uses file_sorter that puts temporary files in the working
directory by default, which is not writable by emqx user since
58d0f04.

One of the consequences is that users cannot access retained messages
from the dashboard, but there are likely other issues as well.

This patch fixes this by making /opt/emqx directory owned by emqx:emqx.
@id id merged commit 9b65c12 into emqx:release-56 Apr 16, 2024
167 checks passed
@id id deleted the 0416-docker-chown-workdir branch April 16, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants