Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule events): don't list validation failure event in CE API #12952

Merged

Conversation

thalesmg
Copy link
Contributor

@thalesmg thalesmg commented Apr 29, 2024

Fixes https://emqx.atlassian.net/browse/EMQX-12284

Release version: e5.7

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@thalesmg thalesmg marked this pull request as ready for review April 29, 2024 20:02
@thalesmg thalesmg requested review from kjellwinblad and a team as code owners April 29, 2024 20:02
@thalesmg thalesmg force-pushed the fix-dont-list-mv-rule-event-r57-20240429 branch 3 times, most recently from f3920d8 to 9056fa6 Compare April 29, 2024 20:42
@thalesmg thalesmg marked this pull request as draft April 29, 2024 20:46
@thalesmg thalesmg force-pushed the fix-dont-list-mv-rule-event-r57-20240429 branch from 9056fa6 to 85eee2c Compare April 29, 2024 20:56
@thalesmg thalesmg force-pushed the fix-dont-list-mv-rule-event-r57-20240429 branch from 85eee2c to 7a44746 Compare April 30, 2024 17:41
@thalesmg thalesmg marked this pull request as ready for review April 30, 2024 18:30
@thalesmg thalesmg changed the title fix(rule events): don't list validation failures in CE fix(rule events): don't list validation failure event in CE API Apr 30, 2024
@thalesmg thalesmg merged commit 607bf0f into emqx:release-57 May 2, 2024
169 checks passed
@thalesmg thalesmg deleted the fix-dont-list-mv-rule-event-r57-20240429 branch May 2, 2024 12:20
@emqxqa
Copy link

emqxqa commented May 8, 2024

Test Execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants