Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): add new hook && event client.check_authn_complete #12983

Merged
merged 3 commits into from
May 9, 2024

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented May 7, 2024

Fixes EMQX-12135

Release version: v/e5.8.0

Summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@lafirest lafirest marked this pull request as ready for review May 7, 2024 12:11
@lafirest lafirest requested review from kjellwinblad and a team as code owners May 7, 2024 12:11
@zmstone
Copy link
Member

zmstone commented May 7, 2024

add a changelog.

@lafirest lafirest merged commit 23a1b18 into master May 9, 2024
173 checks passed
@lafirest lafirest deleted the feat/authn_hook branch May 9, 2024 14:36
[
{<<"clientid">>, [<<"c_emqx">>, <<"the clientid if the client">>]},
{<<"username">>, [<<"u_emqx">>, <<"the username if the client">>]},
{<<"reason_code">>, [<<"sucess">>, <<"the reason code">>]},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

@emqxqa
Copy link

emqxqa commented Jun 14, 2024

TestExecution

id added a commit to emqx/emqx-docs that referenced this pull request Jun 26, 2024
wivwiv pushed a commit to emqx/emqx-docs that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants