Use leader's clock when calculating LTS cutoff timestamp #12998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
reviewed
May 9, 2024
| {State, Result}; | ||
| apply( | ||
| _RaftMeta, | ||
| #{?tag := storage_event, ?payload := CustomEvent, ?now := Now}, |
There was a problem hiding this comment.
Tiny nit: for some reason, dialyzer didn't complain about this new tag in ra_command(). 🙈
thalesmg
reviewed
May 9, 2024
keynslug
reviewed
May 13, 2024
| ?tp(emqx_ds_storage_layer_store_batch, #{ | ||
| shard => Shard, messages => Messages, options => Options | ||
| }), | ||
| case prepare_batch(Shard, Messages, Options) of |
There was a problem hiding this comment.
Q: Should this piece of code eventually end up in what's now ra_store_batch/3?
ieQu1
force-pushed
the
dev/improve-latency
branch
from
b6ecec8
to
9f7ef9f
Compare
keynslug
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12198
Release version: v/e5.7
Summary
This PR fixes clock skew issues that could lead to the loss of messages during replay of the messages in the current epoch of LTS storage.
On the storage layer, this PR also separates preparation of the batch from committing it.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update