Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dsrepl): anticipate and handle nodes leaving the cluster #13054

Merged
merged 4 commits into from
May 17, 2024

Conversation

keynslug
Copy link
Contributor

@keynslug keynslug commented May 15, 2024

Fixes EMQX-12365.

Release version: v5.7

Summary

Attempt to bring together the DS's view of the cluster with mria/ekka's view and related operations, e.g. leave and force-leave.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

ieQu1
ieQu1 previously approved these changes May 16, 2024
@ieQu1
Copy link
Member

ieQu1 commented May 16, 2024

Q: is it possible to display emqx_ds_replication_layer_meta:replica_set_transitions in the status?

Also make `claim_site/2` safer by refusing to claim a site for a node
that is already there.
@ieQu1
Copy link
Member

ieQu1 commented May 16, 2024

The output looks a bit crooked:

THIS SITE:
D8894F95DC86DFDB

SITES:
5C6028D6CE9459C7    'emqx@n2.local'        up
D8894F95DC86DFDB    'emqx@n1.local'        up
F4E92DEA197C8EBC    'emqx@n3.local'        up

SHARDS:
Shard                         Replicas
messages/0                        5C6028D6CE9459C7
messages/1                        5C6028D6CE9459C7
messages/10                       5C6028D6CE9459C7
messages/11                       5C6028D6CE9459C7
messages/2                        5C6028D6CE9459C7
messages/3                        5C6028D6CE9459C7
messages/4                        5C6028D6CE9459C7
messages/5                        5C6028D6CE9459C7
messages/6                        5C6028D6CE9459C7
messages/7                        5C6028D6CE9459C7
messages/8                        5C6028D6CE9459C7
messages/9                        5C6028D6CE9459C7

@keynslug keynslug marked this pull request as ready for review May 17, 2024 07:27
@keynslug keynslug requested review from a team and lafirest as code owners May 17, 2024 07:27
@keynslug
Copy link
Contributor Author

The output looks a bit crooked:

Yeah, that's a consequence of that space is now used for markers denoting down / non-existent sites. 🫠 Will fix in a followup.

@keynslug keynslug merged commit 86f9995 into emqx:release-57 May 17, 2024
168 checks passed
@emqxqa
Copy link

emqxqa commented May 17, 2024

TestExecution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants