-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dsrepl): anticipate and handle nodes leaving the cluster #13054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieQu1
previously approved these changes
May 16, 2024
Q: is it possible to display |
Also make `claim_site/2` safer by refusing to claim a site for a node that is already there.
keynslug
force-pushed
the
fix/EMQX-12365/node-leave
branch
from
May 16, 2024 16:32
02a0a0a
to
26c4a4f
Compare
ieQu1
approved these changes
May 16, 2024
The output looks a bit crooked:
|
Yeah, that's a consequence of that space is now used for markers denoting down / non-existent sites. 🫠 Will fix in a followup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-12365.
Release version: v5.7
Summary
Attempt to bring together the DS's view of the cluster with mria/ekka's view and related operations, e.g. leave and force-leave.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md
filesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket