fix: add action rendered trace for s3 in aggregated mode #13100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
reviewed
May 23, 2024
| @@ -372,6 +379,13 @@ run_aggregated_upload(InstId, Records, #{aggreg_id := AggregId}) -> | |||
| {error, {unrecoverable_error, Reason}} | |||
| end. | |||
|
|
|||
| render_records(Records) -> | |||
| try | |||
| [unicode:characters_to_binary(R) || R <- Records] | |||
There was a problem hiding this comment.
Q: Records are maps 99.9% of time, productions of a Rule SQL expression, to be more specific. I wonder why do we attempt to stringify them like that first?
There was a problem hiding this comment.
You are right. This was done for non-aggregate mode so I assumed we should do the same for aggregate mode as well but I see now that this is incorrect. In non-aggregate mode we render a template. I will fix. Btw, I accidentally pushed a commit for another issue to this PR. Do you think you can review that one as well so we can merge both with the same PR?
There was a problem hiding this comment.
Removed the formatting here: 89b47e8
This commit makes sure that the trace setting for payload encode works even when the payload is in a nested structure or when the payload key is a binary instead of an atom. Fixes: https://emqx.atlassian.net/browse/EMQX-12424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://emqx.atlassian.net/browse/EMQX-12429
Manually tested
Release version: v/e5.?
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfiles