Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve topic alias maximum and receive maximum #1873

Merged
merged 5 commits into from
Sep 29, 2018
Merged

Improve topic alias maximum and receive maximum #1873

merged 5 commits into from
Sep 29, 2018

Conversation

tigercl
Copy link
Member

@tigercl tigercl commented Sep 29, 2018

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Sep 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 3425

  • 20 of 35 (57.14%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 57.006%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_packet.erl 0 1 0.0%
src/emqx_session.erl 7 10 70.0%
src/emqx_protocol.erl 11 22 50.0%
Files with Coverage Reduction New Missed Lines %
src/emqx_protocol.erl 1 57.85%
Totals Coverage Status
Change from base Build 3418: 0.4%
Covered Lines: 2384
Relevant Lines: 4182
💛 - Coveralls

@huangdan huangdan merged commit 1638aff into emqx30 Sep 29, 2018
@huangdan huangdan added this to the 3.0-beta.4 milestone Sep 29, 2018
@tigercl tigercl deleted the connect_improve branch October 9, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huangdan huangdan huangdan approved these changes

@gilbertwong96 gilbertwong96 gilbertwong96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0-beta.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tigercl @coveralls @huangdan @gilbertwong96