Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace macro QOS$i to QOS_$I #1948

Merged
merged 1 commit into from Nov 8, 2018

Conversation

@gilbertwong96
Copy link
Contributor

gilbertwong96 commented Nov 6, 2018

  • The two styles of qos macro name in one project is chaotic. It is not
    good practice. So I change the QOS$i to QOS_$i

  • The emqx_protocol_SUITE.erl.bk is outdated and unnecessary, So I delete it.

The two styles of qos macro name in one project is chaotic. It is not
a good practice.

So I change the QOS$i to QOS_$i
@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 6, 2018

Pull Request Test Coverage Report for Build 3730

  • 5 of 6 (83.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.486%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_client.erl 0 1 0.0%
Totals Coverage Status
Change from base Build 3728: 0.0%
Covered Lines: 2728
Relevant Lines: 4297

💛 - Coveralls
@turtleDeng turtleDeng merged commit 32d3826 into emqx30 Nov 8, 2018
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 63.486%
Details
@emqplus emqplus deleted the replace-qos-name branch Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.