Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix will message mechanism for websocket channel #2680

Merged
merged 2 commits into from Jul 11, 2019
Merged

Fix will message mechanism for websocket channel #2680

merged 2 commits into from Jul 11, 2019

Conversation

gilbertwong96
Copy link
Contributor

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Jul 9, 2019 •
edited

Pull Request Test Coverage Report for Build 5959

  • 7 of 9 (77.78%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 69.647%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/emqx_ws_channel.erl 4 6 66.67%
Files with Coverage Reduction New Missed Lines %
src/emqx_protocol.erl 1 78.92%
src/emqx_channel.erl 1 62.87%
Totals Coverage Status
Change from base Build 5945: -0.002%
Covered Lines: 3373
Relevant Lines: 4843
💛 - Coveralls

HJianBo
HJianBo requested changes Jul 9, 2019
View reviewed changes
src/emqx_ws_channel.erl Outdated Show resolved Hide resolved
@turtleDeng turtleDeng merged commit bf89646 into develop Jul 11, 2019
@turtleDeng turtleDeng deleted the fix-ws-will branch July 11, 2019 01:44
@gilbertwong96 gilbertwong96 mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo requested changes

@emqplus emqplus Awaiting requested review from emqplus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gilbertwong96 @coveralls @HJianBo @turtleDeng