New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/william/v4.2.12 #4732
Merged
Merged
Backport/william/v4.2.12 #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use global lock to reduce remote lock overhead. So that emqx route trans can run in dirty *sync* context. At least 10X subscribe/unsubscribe improvments.
So change broker call timeout to infinity.
intro. new lock type: 'spawn' of broker.perf.route_lock_type mnesia get lock calls are not optimized for selective receive. hence taking locks would be very expensive while there are tones of messages in the brokers message queue. This optimization run the transaction in a separate process to utilize the selective receive optimization of the compiler.
qzhuyan
force-pushed
the
backport/william/v4.2.12
branch
from
May 4, 2021 07:18
124bd76
to
ce15b76
Compare
k32
previously approved these changes
May 4, 2021
zmstone
reviewed
May 4, 2021
zmstone
reviewed
May 4, 2021
qzhuyan
force-pushed
the
backport/william/v4.2.12
branch
from
May 4, 2021 07:25
ce15b76
to
593b030
Compare
zmstone
reviewed
May 4, 2021
zmstone
previously approved these changes
May 4, 2021
qzhuyan
force-pushed
the
backport/william/v4.2.12
branch
from
May 4, 2021 08:43
7f783f0
to
bd19980
Compare
It is meaningless to do elvis checks on maintenance branches.
zmstone
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport fixes to 4.2 for the following issues:
#2671
#2985
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Backward Compatibility
More information