refactor: authz-http return body to reject pub/sub #8377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimMoen
requested changes
Jul 1, 2022
JimMoen
force-pushed
the
refactor-http-authz-resp
branch
from
60863ce
to
83f5da8
Compare
tigercl
approved these changes
Jul 1, 2022
zmstone
reviewed
Jul 1, 2022
| @@ -130,6 +132,25 @@ render_sql_params(ParamList, Values) -> | |||
| #{return => rawlist, var_trans => fun handle_sql_var/2} | |||
| ). | |||
|
|
|||
| -spec parse_http_resp_body(binary(), binary()) -> allow | deny | ignore | error. | |||
| parse_http_resp_body(<<"application/x-www-form-urlencoded", _/binary>>, Body) -> | |||
There was a problem hiding this comment.
This breaks backward compatibility?
We should also check if the body is empty, then fallback to the old behavior?
5.0.0 and 4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.