Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authz): should apply no rule on superuser #8452

Merged
merged 3 commits into from Jul 8, 2022
Merged

fix(authz): should apply no rule on superuser #8452

merged 3 commits into from Jul 8, 2022

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Jul 8, 2022 •
edited

fixes #8446

@zmstone zmstone force-pushed the 0708-fix-authz-no-rule-apply-for-superuser branch 2 times, most recently from 2916b4f to e362608 Compare July 8, 2022 09:05
@zmstone zmstone requested a review from a team July 8, 2022 09:08
@zmstone zmstone force-pushed the 0708-fix-authz-no-rule-apply-for-superuser branch from e362608 to 71da5eb Compare July 8, 2022 09:09
@zmstone zmstone marked this pull request as ready for review July 8, 2022 09:31
@zmstone zmstone force-pushed the 0708-fix-authz-no-rule-apply-for-superuser branch from 71da5eb to fb0154f Compare July 8, 2022 11:15
thalesmg
thalesmg previously approved these changes Jul 8, 2022
View reviewed changes
CHANGES-5.0.md Outdated Show resolved Hide resolved
savonarola
savonarola previously approved these changes Jul 8, 2022
View reviewed changes
thalesmg
thalesmg previously approved these changes Jul 8, 2022
View reviewed changes
@zmstone zmstone dismissed stale reviews from thalesmg and savonarola via 944e673 July 8, 2022 20:33
@zmstone zmstone force-pushed the 0708-fix-authz-no-rule-apply-for-superuser branch from 944e673 to 8bf5c20 Compare July 8, 2022 20:36
@zmstone zmstone merged commit 8b7e9a2 into emqx:master Jul 8, 2022
@zmstone zmstone deleted the 0708-fix-authz-no-rule-apply-for-superuser branch July 8, 2022 20:37
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2638456234

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.03%) to 78.846%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_authz/src/emqx_authz.erl 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
apps/emqx_machine/src/emqx_machine.erl 1 79.31%
apps/emqx_slow_subs/src/emqx_slow_subs.erl 1 77.42%
apps/emqx/src/emqx_broker.erl 1 81.87%
apps/emqx/src/emqx_channel.erl 1 86.01%
apps/emqx/src/emqx_cm.erl 1 88.99%
apps/emqx/src/emqx_frame.erl 1 88.41%
apps/emqx/src/emqx_message.erl 1 94.12%
apps/emqx/src/emqx_schema.erl 1 90.91%
apps/emqx_resource/src/emqx_resource_manager.erl 2 88.24%
apps/emqx/src/emqx_flapping.erl 3 80.85%
Totals Coverage Status
Change from base Build 2637915806: 0.03%
Covered Lines: 20820
Relevant Lines: 26406
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savonarola savonarola savonarola left review comments

@thalesmg thalesmg thalesmg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Superuser Not Working
4 participants
@zmstone @coveralls @savonarola @thalesmg