Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hocon required fields #8458

Merged
merged 5 commits into from Jul 13, 2022
Merged

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Jul 11, 2022

redis sentinal name should be required.
see Redis configuring sentinel

jwks ssl options using genernal fields schema in emqx_schema

@JimMoen JimMoen force-pushed the fix-hocon-required-fields branch 3 times, most recently from 6b3e586 to 1e53c74 Compare July 12, 2022 06:10
@JimMoen JimMoen marked this pull request as ready for review July 12, 2022 06:31
@coveralls
Copy link
Collaborator

coveralls commented Jul 12, 2022

Pull Request Test Coverage Report for Build 2660636108

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 37 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.05%) to 78.799%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/emqx_gateway_schema.erl 1 90.0%
apps/emqx_machine/src/emqx_machine.erl 1 79.31%
apps/emqx_management/src/emqx_mgmt_util.erl 1 13.79%
apps/emqx/src/emqx_authentication_config.erl 1 84.75%
apps/emqx/src/emqx_broker.erl 1 81.87%
apps/emqx/src/emqx_channel.erl 1 86.01%
apps/emqx/src/emqx_cm.erl 1 88.53%
apps/emqx/src/emqx_frame.erl 1 88.41%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx_gateway/src/emqx_gateway_cm.erl 2 74.78%
Totals Coverage Status
Change from base Build 2660599433: -0.05%
Covered Lines: 20795
Relevant Lines: 26390

💛 - Coveralls

HJianBo
HJianBo previously approved these changes Jul 12, 2022
@JimMoen JimMoen merged commit 6b2b0e5 into emqx:master Jul 13, 2022
@JimMoen JimMoen deleted the fix-hocon-required-fields branch July 13, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants