Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: list rules support for pagination and fuzzy filtering #8472

Merged
merged 1 commit into from Jul 25, 2022
Merged

feat: list rules support for pagination and fuzzy filtering #8472

merged 1 commit into from Jul 25, 2022

Conversation

zhongwencool
Copy link
Member

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Jul 13, 2022 •
edited

Pull Request Test Coverage Report for Build 2729343068

  • 23 of 26 (88.46%) changed or added relevant lines in 1 file are covered.
  • 32 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.003%) to 78.824%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_rule_engine/src/emqx_rule_engine_api.erl 23 26 88.46%
Files with Coverage Reduction New Missed Lines %
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 1 69.44%
apps/emqx_gateway/src/emqx_gateway_schema.erl 1 90.0%
apps/emqx_rule_engine/src/emqx_rule_engine.erl 1 83.0%
apps/emqx/src/emqx_cm.erl 1 88.99%
apps/emqx/src/emqx_listeners.erl 1 83.94%
apps/emqx/src/emqx_olp.erl 1 77.78%
apps/emqx/src/emqx_sys_mon.erl 1 90.63%
apps/emqx_rule_engine/src/emqx_rule_engine_api.erl 2 79.21%
apps/emqx/src/emqx_flapping.erl 3 80.85%
apps/emqx/src/emqx_channel.erl 6 85.85%
Totals Coverage Status
Change from base Build 2720308633: -0.003%
Covered Lines: 20853
Relevant Lines: 26455
💛 - Coveralls

@zhongwencool zhongwencool force-pushed the list-rules-with-filter-5.0 branch 2 times, most recently from 5285ae8 to 4be85d3 Compare July 18, 2022 01:36
@zhongwencool zhongwencool merged commit adcd899 into emqx:master Jul 25, 2022
@zhongwencool zhongwencool deleted the list-rules-with-filter-5.0 branch July 25, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigercl tigercl tigercl approved these changes

@terry-xiaoyu terry-xiaoyu Awaiting requested review from terry-xiaoyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongwencool @coveralls @tigercl