Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persistent_sessions): don't use rocksdb when unavailable #8528

Merged
merged 1 commit into from
Jul 22, 2022
Merged

feat(persistent_sessions): don't use rocksdb when unavailable #8528

merged 1 commit into from
Jul 22, 2022

Conversation

thalesmg
Copy link
Contributor

No description provided.

@thalesmg thalesmg force-pushed the persistent-session-optional-rocksdb branch from 589079c to f51a6ec Compare July 20, 2022 18:22
codeball-ai-writer[bot]
codeball-ai-writer bot approved these changes Jul 20, 2022
View reviewed changes
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍 dashboard

codeball-ai-writer[bot]
codeball-ai-writer bot previously approved these changes Jul 20, 2022
View reviewed changes
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍 dashboard

@thalesmg thalesmg force-pushed the persistent-session-optional-rocksdb branch from f51a6ec to b636d08 Compare July 20, 2022 19:38
codeball-ai-writer[bot]
codeball-ai-writer bot previously approved these changes Jul 20, 2022
View reviewed changes
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍 dashboard

@thalesmg thalesmg marked this pull request as ready for review July 20, 2022 21:49
ieQu1
ieQu1 previously approved these changes Jul 21, 2022
View reviewed changes
@thalesmg thalesmg dismissed stale reviews from ieQu1 and codeball-ai-writer via a958c68 July 21, 2022 12:50
@thalesmg thalesmg force-pushed the persistent-session-optional-rocksdb branch from b636d08 to a958c68 Compare July 21, 2022 12:50
@thalesmg
Copy link
Contributor Author

Had to rebase because of a conflict in CHANGES-v5.0.md.

@thalesmg
Copy link
Contributor Author

Mix build is failing because of this: elixir-lang/elixir#12000

@thalesmg thalesmg force-pushed the persistent-session-optional-rocksdb branch from a958c68 to a9eb8c8 Compare July 21, 2022 14:18
@thalesmg thalesmg linked an issue Jul 21, 2022 that may be closed by this pull request
optional rocksdb #8457
Closed
@thalesmg thalesmg requested review from ieQu1 and a team July 21, 2022 14:57
ieQu1
ieQu1 previously approved these changes Jul 22, 2022
View reviewed changes
zmstone
zmstone previously approved these changes Jul 22, 2022
View reviewed changes
@zmstone
Copy link
Member

zmstone commented Jul 22, 2022

hmm conflicts.

@thalesmg thalesmg dismissed stale reviews from zmstone and ieQu1 via 7d01e56 July 22, 2022 12:11
@thalesmg thalesmg force-pushed the persistent-session-optional-rocksdb branch from a9eb8c8 to 7d01e56 Compare July 22, 2022 12:11
@thalesmg
Copy link
Contributor Author

@zmstone @ieQu1 Yet another changelog conflict 🙈

Should be resolved for the next few minutes at least 🤞

@thalesmg thalesmg requested review from zmstone and ieQu1 July 22, 2022 12:16
@thalesmg
Copy link
Contributor Author

Can't believe I hit another digit-only-starting-with-zero git hash... 🙈

https://github.com/emqx/emqx/runs/7467994847?check_suite_focus=true#step:6:12196

@thalesmg thalesmg force-pushed the persistent-session-optional-rocksdb branch from 7d01e56 to 343a78b Compare July 22, 2022 13:59
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2719073195

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 78.771%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx/src/persistent_session/emqx_persistent_session_backend_builtin.erl 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
apps/emqx/src/emqx_config.erl 1 84.83%
apps/emqx/src/emqx_connection.erl 1 84.7%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_frame.erl 1 88.41%
apps/emqx/src/emqx_router_utils.erl 1 58.14%
apps/emqx_gateway/src/emqx_gateway_cm.erl 3 73.45%
apps/emqx/src/emqx_channel.erl 3 85.53%
apps/emqx/src/emqx_sys_mon.erl 6 86.46%
apps/emqx/src/emqx_reason_codes.erl 14 88.97%
Totals Coverage Status
Change from base Build 2719068658: 0.02%
Covered Lines: 20820
Relevant Lines: 26431
💛 - Coveralls

@thalesmg thalesmg requested a review from a team July 22, 2022 16:45
@thalesmg thalesmg merged commit 7ad0dc7 into emqx:master Jul 22, 2022
@thalesmg thalesmg deleted the persistent-session-optional-rocksdb branch July 22, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ieQu1 ieQu1 ieQu1 approved these changes

@codeball-ai-writer codeball-ai-writer[bot] codeball-ai-writer left review comments

@zmstone zmstone Awaiting requested review from zmstone

Assignees
No one assigned
Labels
codeball:approved Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optional rocksdb
4 participants
@thalesmg @zmstone @coveralls @ieQu1