Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jwt): support non-integer timestamp claims #8867

Merged
merged 3 commits into from Sep 2, 2022
Merged

fix(jwt): support non-integer timestamp claims #8867

merged 3 commits into from Sep 2, 2022

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Sep 1, 2022

fix #8825

@lafirest lafirest requested a review from a team September 1, 2022 10:56
codeball-ai-writer[bot]
codeball-ai-writer bot previously approved these changes Sep 1, 2022
View reviewed changes
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.97 | [dashboard] | [adjust AI settings]

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2971035650

  • 10 of 15 (66.67%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 77.444%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_authn/src/simple_authn/emqx_authn_jwt.erl 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge/src/emqx_bridge.erl 1 85.11%
apps/emqx_management/src/emqx_mgmt_util.erl 1 13.79%
apps/emqx/src/emqx_frame.erl 1 88.41%
apps/emqx/src/emqx_listeners.erl 1 84.23%
apps/emqx/src/emqx_schema.erl 1 90.91%
apps/emqx/src/emqx_flapping.erl 3 80.85%
apps/emqx/src/emqx_reason_codes.erl 16 86.76%
Totals Coverage Status
Change from base Build 2968442782: 0.02%
Covered Lines: 20600
Relevant Lines: 26600
💛 - Coveralls

@lafirest lafirest merged commit cffdcb4 into emqx:master Sep 2, 2022
@lafirest lafirest deleted the fix/jwt_exp_v5 branch September 2, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo approved these changes

@codeball-ai-writer codeball-ai-writer[bot] codeball-ai-writer left review comments

Assignees
No one assigned
Labels
codeball:approved Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JWT token authentication fails due on non-integer timestamp claims
3 participants
@lafirest @coveralls @HJianBo