-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cluster/local-override.conf does not take effect at vm.args/app.config #8895
Conversation
Pull Request Test Coverage Report for Build 3049662246
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix emqx.cmd for windows too.
also: test space in data dir.
7067019
to
f5e25d0
Compare
I'm not familiar with cmd on windows, |
bf92d33
to
ac7e27f
Compare
will fix windows in another PR. |
bb351b1
to
4133e63
Compare
4133e63
to
313118d
Compare
902b75c
to
ecdd6b0
Compare
ecdd6b0
to
cdbcefb
Compare
as discussed.
|
Config changes such as log levels etc can be applied from dashboard in realtime.
However due to the sys.config (or app.config) generation did not take cluster-override (nor local-override) into account.
such config change are not persisted.
This PR tries to include both cluster and local overrides into config generation stage.
Fix
emqx.cmd
for Windows in another PR.