Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retainer): fix that EMQX can't start when the retainer is disabled #8911

Merged
merged 3 commits into from Sep 9, 2022

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Sep 7, 2022

Reproduce steps:

  1. Start an emqx and disable the Retainer
  2. Restarting emqx will report the following error

image

codeball-ai-writer[bot]
codeball-ai-writer bot previously approved these changes Sep 7, 2022
Copy link

@codeball-ai-writer codeball-ai-writer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.98 | [dashboard] | [adjust AI settings]

@coveralls
Copy link
Collaborator

coveralls commented Sep 7, 2022

Pull Request Test Coverage Report for Build 3014601779

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 78 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.09%) to 77.323%

Files with Coverage Reduction New Missed Lines %
apps/emqx_conf/src/emqx_conf_schema.erl 1 92.31%
apps/emqx_connector/src/emqx_connector_http.erl 1 71.19%
apps/emqx_machine/src/emqx_machine.erl 1 79.31%
apps/emqx_resource/src/emqx_resource_manager.erl 1 87.25%
apps/emqx/src/emqx_broker.erl 1 81.87%
apps/emqx/src/emqx_stats.erl 1 93.33%
apps/emqx/src/emqx_ws_connection.erl 1 79.01%
apps/emqx/src/emqx_alarm.erl 2 91.74%
apps/emqx/src/emqx_channel.erl 2 86.36%
apps/emqx_management/src/emqx_mgmt_cli.erl 5 29.37%
Totals Coverage Status
Change from base Build 3005506636: -0.09%
Covered Lines: 20605
Relevant Lines: 26648

💛 - Coveralls

@lafirest lafirest requested a review from a team September 7, 2022 08:14
@lafirest lafirest merged commit 6794551 into emqx:master Sep 9, 2022
@lafirest lafirest deleted the fix/retainer_start_error branch September 9, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants