New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: authentication should be array, not struct #8924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwencool
force-pushed
the
authn-config-check
branch
from
September 14, 2022 02:47
78e6b56
to
4d375ea
Compare
Pull Request Test Coverage Report for Build 3049800820
💛 - Coveralls |
could you post the new error message (in case e.g. mechanism is missing as reported in the issue)? |
zmstone
reviewed
Sep 15, 2022
|
zhongwencool
force-pushed
the
authn-config-check
branch
from
September 15, 2022 10:09
3f88aa2
to
fe92819
Compare
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
zhongwencool
force-pushed
the
authn-config-check
branch
from
September 16, 2022 01:45
fe92819
to
5056cbe
Compare
thalesmg
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feasible to test? If so, it might be worth adding a test case for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix: #8784