Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge/authz/exhook): no need to drop invalid certs #8958

Merged

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Sep 14, 2022

revert parts of #8872. remove useless code.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3050554873

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • 26 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.03%) to 77.554%

Files with Coverage Reduction New Missed Lines %
apps/emqx_authn/src/simple_authn/emqx_authn_jwt.erl 1 85.8%
apps/emqx_slow_subs/src/emqx_slow_subs.erl 1 77.42%
apps/emqx/src/emqx_broker.erl 1 82.42%
apps/emqx/src/emqx_frame.erl 1 88.41%
apps/emqx/src/emqx_limiter/src/emqx_limiter_server.erl 1 89.08%
apps/emqx/src/emqx_logger_textfmt.erl 1 47.37%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx/src/emqx_cm.erl 2 88.99%
apps/emqx/src/emqx_channel.erl 3 86.36%
apps/emqx/src/emqx_reason_codes.erl 7 92.65%
Totals Coverage Status
Change from base Build 3049658358: 0.03%
Covered Lines: 20720
Relevant Lines: 26717

💛 - Coveralls

@terry-xiaoyu terry-xiaoyu merged commit d9c9a1d into emqx:release-v5.0.8 Sep 15, 2022
@JimMoen JimMoen deleted the fix-ssl-drop-invalid-certs branch September 16, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants