Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: respect PKG_VSN in pkg-vsn.sh #9089

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

id
Copy link
Collaborator

@id id commented Oct 3, 2022

No changes in logic. Right now the same happens on line #110 in the current version: if PKG_VSN is set, and --long is not given, we just return PKG_VSN.

In the current version though, even if you set PKG_VSN, the script will still attempt to extract version from git. This fails to produce correct version if one tries to build emqx from source code archive (with no .git), and consequently fails the build.

pkg-vsn.sh Outdated Show resolved Hide resolved
pkg-vsn.sh Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Oct 3, 2022

Pull Request Test Coverage Report for Build 3176349197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.02%) to 77.968%

Files with Coverage Reduction New Missed Lines %
apps/emqx_authz/src/emqx_authz_schema.erl 1 90.28%
apps/emqx_conf/src/emqx_conf_schema.erl 1 92.31%
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 72.92%
apps/emqx_management/src/emqx_mgmt_api_trace.erl 1 80.0%
apps/emqx/src/emqx_broker.erl 1 81.87%
apps/emqx/src/emqx_cm.erl 1 88.99%
apps/emqx/src/emqx_limiter/src/emqx_limiter_server.erl 1 89.08%
apps/emqx/src/emqx_listeners.erl 1 85.12%
apps/emqx/src/emqx_ws_connection.erl 1 79.28%
apps/emqx_gateway/src/exproto/emqx_exproto_gcli.erl 3 48.78%
Totals Coverage Status
Change from base Build 3152209479: -0.02%
Covered Lines: 20723
Relevant Lines: 26579

💛 - Coveralls

@id id force-pushed the chore-always-respect-PKG_VSN branch from 2ce0e0f to bc71149 Compare October 3, 2022 18:02
@id id merged commit 8003cba into master Oct 5, 2022
@id id deleted the chore-always-respect-PKG_VSN branch October 5, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants