chore: respect PKG_VSN in pkg-vsn.sh #9089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes in logic. Right now the same happens on line #110 in the current version: if
PKG_VSN
is set, and--long
is not given, we just returnPKG_VSN
.In the current version though, even if you set
PKG_VSN
, the script will still attempt to extract version from git. This fails to produce correct version if one tries to build emqx from source code archive (with no.git
), and consequently fails the build.