Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: multicall node_info to improve /node speed #9221

Merged
merged 6 commits into from Oct 28, 2022

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Oct 24, 2022

Getting all nodes' info API is too slow when there are many nodes in the cluster.
So replace rpc:call with erpc:multicall

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3337214947

  • 20 of 39 (51.28%) changed or added relevant lines in 3 files are covered.
  • 35 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.07%) to 78.054%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_management/src/proto/emqx_management_proto_v3.erl 4 10 40.0%
apps/emqx_management/src/emqx_mgmt.erl 15 28 53.57%
Files with Coverage Reduction New Missed Lines %
apps/emqx_modules/src/emqx_telemetry.erl 1 81.5%
apps/emqx/src/emqx_authentication_config.erl 1 83.62%
apps/emqx/src/emqx_connection.erl 1 87.36%
apps/emqx/src/emqx_listeners.erl 1 85.12%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_stats.erl 1 93.33%
apps/emqx_authn/src/emqx_authn.erl 2 75.0%
apps/emqx_resource/src/emqx_resource_manager.erl 2 87.75%
apps/emqx_management/src/proto/emqx_management_proto_v2.erl 4 20.0%
apps/emqx_management/src/emqx_mgmt_cli.erl 5 29.37%
Totals Coverage Status
Change from base Build 3335837932: -0.07%
Covered Lines: 20863
Relevant Lines: 26729

💛 - Coveralls

thalesmg
thalesmg previously approved these changes Oct 27, 2022
changes/v5.0.10-zh.md Outdated Show resolved Hide resolved
changes/v5.0.10-en.md Outdated Show resolved Hide resolved
@zmstone
Copy link
Member

zmstone commented Oct 27, 2022

LGTM otherwise.

@zhongwencool zhongwencool merged commit 902f82d into emqx:master Oct 28, 2022
@zhongwencool zhongwencool deleted the multicall-node-api branch October 28, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants