New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: multicall node_info to improve /node speed #9221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwencool
force-pushed
the
multicall-node-api
branch
from
October 27, 2022 01:39
915f79d
to
26e1dbb
Compare
codeball-ai-writer
bot
added
codeball:needs-careful-review
Codeball
and removed
codeball:approved
Codeball
labels
Oct 27, 2022
zhongwencool
force-pushed
the
multicall-node-api
branch
2 times, most recently
from
October 27, 2022 12:05
d0ad5f1
to
ae2633f
Compare
thalesmg
previously approved these changes
Oct 27, 2022
zmstone
reviewed
Oct 27, 2022
LGTM otherwise. |
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
zhongwencool
force-pushed
the
multicall-node-api
branch
from
October 28, 2022 01:16
32e9989
to
72163c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting all nodes' info API is too slow when there are many nodes in the cluster.
So replace
rpc:call
witherpc:multicall