New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve MQTTv5 properties in Rules/Bridges #9240
Merged
zmstone
merged 9 commits into
emqx:1121-rule-bridge-properties
from
kraftwerk28:rule-bridge-properties
Nov 21, 2022
Merged
Preserve MQTTv5 properties in Rules/Bridges #9240
zmstone
merged 9 commits into
emqx:1121-rule-bridge-properties
from
kraftwerk28:rule-bridge-properties
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftwerk28
commented
Oct 26, 2022
kraftwerk28
commented
Oct 26, 2022
@zmstone can you please allow workflows run? |
kraftwerk28
changed the title
feat: do not drop MQTTv5 properties in rule/bridge
Preserve MQTTv5 properties in Rules/Bridges
Nov 3, 2022
@zmstone can you please one more time allow workflows to run? We can't do more with that PR now :( |
zmstone
reviewed
Nov 8, 2022
zmstone
reviewed
Nov 8, 2022
zmstone
reviewed
Nov 8, 2022
zmstone
reviewed
Nov 8, 2022
zmstone
reviewed
Nov 8, 2022
zmstone
reviewed
Nov 9, 2022
kraftwerk28
force-pushed
the
rule-bridge-properties
branch
from
November 11, 2022 15:51
968a991
to
9464f88
Compare
zmstone
reviewed
Nov 16, 2022
kraftwerk28
force-pushed
the
rule-bridge-properties
branch
from
November 18, 2022 10:15
e005f4b
to
6215b52
Compare
Pull Request Test Coverage Report for Build 3496038578
💛 - Coveralls |
Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9179
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/
dirappup
files updated (executescripts/update-appup.sh emqx
)Backward Compatibility
More information