Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve MQTTv5 properties in Rules/Bridges #9240

Merged

Conversation

kraftwerk28
Copy link
Contributor

@kraftwerk28 kraftwerk28 commented Oct 26, 2022

Fixes #9179

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change, and another jira tickt to track doc updates (if any)
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@nosovk
Copy link

nosovk commented Oct 27, 2022

@zmstone can you please allow workflows run?

@kraftwerk28 kraftwerk28 changed the title feat: do not drop MQTTv5 properties in rule/bridge Preserve MQTTv5 properties in Rules/Bridges Nov 3, 2022
@nosovk
Copy link

nosovk commented Nov 8, 2022

@zmstone can you please one more time allow workflows to run? We can't do more with that PR now :(

apps/emqx/src/emqx_misc.erl Outdated Show resolved Hide resolved
apps/emqx/src/emqx_misc.erl Outdated Show resolved Hide resolved
changes/v5.0.10-en.md Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3496038578

  • 11 of 14 (78.57%) changed or added relevant lines in 3 files are covered.
  • 28 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.06%) to 78.069%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx/src/emqx_misc.erl 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_channel.erl 1 87.06%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx_conf/src/emqx_conf_schema.erl 1 92.31%
apps/emqx/src/emqx_stats.erl 1 93.33%
apps/emqx/src/emqx_broker.erl 5 82.42%
apps/emqx/src/emqx_sys_mon.erl 6 85.42%
apps/emqx/src/emqx_reason_codes.erl 12 88.97%
Totals Coverage Status
Change from base Build 3494892781: 0.06%
Covered Lines: 20924
Relevant Lines: 26802

💛 - Coveralls

@zmstone zmstone changed the base branch from master to 1121-rule-bridge-properties November 21, 2022 13:05
@zmstone zmstone merged this pull request into emqx:1121-rule-bridge-properties Nov 21, 2022
@zmstone
Copy link
Member

zmstone commented Nov 21, 2022

Thank you for the PR.
I have changed the base to another branch and merged it.
I will rebase and squash your commits, and update app versions and change logs etc in another Pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT bridge does not transmit MQTTv5 properties
4 participants