Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authz API fixes #9299

Merged
merged 6 commits into from Nov 8, 2022
Merged

Authz API fixes #9299

merged 6 commits into from Nov 8, 2022

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Nov 3, 2022

Fixes EMQX-7870
Fixes EMQX-7981

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change, and another jira tickt to track doc updates (if any)
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@sstrigler sstrigler changed the title Authz api fixes WIP Authz API fixes Nov 3, 2022
@sstrigler sstrigler changed the title WIP Authz API fixes Authz API fixes Nov 3, 2022
@coveralls
Copy link
Collaborator

coveralls commented Nov 3, 2022

Pull Request Test Coverage Report for Build 3421638889

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.1%) to 77.966%

Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/emqx_gateway_schema.erl 1 90.0%
apps/emqx/src/emqx_authentication_config.erl 1 83.62%
apps/emqx/src/emqx_cm.erl 1 89.45%
apps/emqx/src/emqx_os_mon.erl 1 82.61%
apps/emqx/src/emqx_reason_codes.erl 12 89.71%
Totals Coverage Status
Change from base Build 3421617086: 0.1%
Covered Lines: 20870
Relevant Lines: 26768

💛 - Coveralls

@@ -75,10 +79,7 @@ schema("/authorization/sources") ->
tags => ?TAGS,
responses =>
#{
200 => mk(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this change is not necessary, the code is correct but the documentation is error, what we need is to update the doc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same question, but it actually turned out to be a schema error
https://github.com/emqx/emqx/pull/9299/files#r1016505227

@@ -30,3 +30,7 @@
`$events/message_dropped`, 如果消息事件是共享订阅产生的,在编码(到 JSON 格式)过程中会失败。

- 修复 HTTP API `/gateways` 的返回状态码,未知 Gateway 名字应返回 `404` 而不是 `400` [#9268](https://github.com/emqx/emqx/pull/9268)。

- Add property `code` to error response for `/authentication/sources/:type`. [9299](https://github.com/emqx/emqx/pull/9299)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore the Chinese version, after you make a new PR you could send a message on slack to me, I'm glad to translate it

@zmstone zmstone merged commit 6515032 into emqx:master Nov 8, 2022
@sstrigler sstrigler deleted the authz-api-fixes branch February 17, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants