New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authz API fixes #9299
Authz API fixes #9299
Conversation
49fd60e
to
b8c185b
Compare
Pull Request Test Coverage Report for Build 3421638889
💛 - Coveralls |
@@ -75,10 +79,7 @@ schema("/authorization/sources") -> | |||
tags => ?TAGS, | |||
responses => | |||
#{ | |||
200 => mk( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe this change is not necessary, the code is correct but the documentation is error, what we need is to update the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same question, but it actually turned out to be a schema error
https://github.com/emqx/emqx/pull/9299/files#r1016505227
changes/v5.0.10-zh.md
Outdated
@@ -30,3 +30,7 @@ | |||
`$events/message_dropped`, 如果消息事件是共享订阅产生的,在编码(到 JSON 格式)过程中会失败。 | |||
|
|||
- 修复 HTTP API `/gateways` 的返回状态码,未知 Gateway 名字应返回 `404` 而不是 `400` [#9268](https://github.com/emqx/emqx/pull/9268)。 | |||
|
|||
- Add property `code` to error response for `/authentication/sources/:type`. [9299](https://github.com/emqx/emqx/pull/9299) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can ignore the Chinese version, after you make a new PR you could send a message on slack to me, I'm glad to translate it
5738fa4
to
4107e34
Compare
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
2fdb9f2
to
467010e
Compare
Fixes EMQX-7870
Fixes EMQX-7981
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/
dirappup
files updated (executescripts/update-appup.sh emqx
)Backward Compatibility
More information