Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the bad change logs introduced in #9307 #9354

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

HJianBo
Copy link
Member

@HJianBo HJianBo commented Nov 11, 2022

In fact, this bug fix merged into the v5.0.11

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3443762744

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 77.893%

Files with Coverage Reduction New Missed Lines %
apps/emqx_bridge/src/emqx_bridge.erl 1 85.11%
apps/emqx/src/emqx_broker.erl 1 82.97%
apps/emqx/src/emqx_cm.erl 1 88.99%
apps/emqx_resource/src/emqx_resource_manager.erl 2 87.75%
apps/emqx/src/emqx_channel.erl 2 87.06%
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 3 68.06%
apps/emqx/src/emqx_reason_codes.erl 7 88.97%
apps/emqx_prometheus/src/emqx_prometheus.erl 11 86.44%
Totals Coverage Status
Change from base Build 3442237962: 0.02%
Covered Lines: 20852
Relevant Lines: 26770

💛 - Coveralls

@HJianBo HJianBo merged commit 5cd31e4 into emqx:master Nov 22, 2022
@HJianBo HJianBo deleted the refine-changes-md branch November 22, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants