Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(JWT): make the exp to be optional claim #9368

Merged
merged 2 commits into from Nov 15, 2022
Merged

fix(JWT): make the exp to be optional claim #9368

merged 2 commits into from Nov 15, 2022

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Nov 15, 2022 •
edited

Fix #9217

According to the spec, the exp should be optional

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
    EMQX-7924
  • ~~ If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up~~
  • ~~ In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section~~

Backward Compatibility

More information

@lafirest lafirest marked this pull request as ready for review November 15, 2022 08:59
@lafirest lafirest requested a review from a team November 15, 2022 08:59
ieQu1
ieQu1 reviewed Nov 15, 2022
View reviewed changes
changes/v5.0.11-en.md
@@ -10,3 +10,5 @@
## Bug fixes

- Return 404 for status of unknown authenticator in `/authenticator/{id}/status` [#9328](https://github.com/emqx/emqx/pull/9328).

- Fix that JWT ACL rules are only applied if an `exp` claim is set [#9368](https://github.com/emqx/emqx/pull/9368).
Copy link
Member

@ieQu1 ieQu1 Nov 15, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fix that JWT ACL rules are only applied if an `exp` claim is set [#9368](https://github.com/emqx/emqx/pull/9368).
- Fix that JWT ACL rules are only applied when `exp` claim is set [#9368](https://github.com/emqx/emqx/pull/9368).

@lafirest lafirest merged commit ff00a67 into emqx:master Nov 15, 2022
@lafirest lafirest deleted the fix/allow_absent_exp branch November 15, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ieQu1 ieQu1 ieQu1 approved these changes

Assignees
No one assigned
Labels
codeball:approved Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JWT acl rules are only applied if an exp claim is set
2 participants
@lafirest @ieQu1