Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make remsh node name away from the atom table overflow #9391

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Nov 18, 2022

Port the #9387 into v4.3

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3494709467

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 75.324%

Files with Coverage Reduction New Missed Lines %
src/emqx_logger.erl 1 86.96%
src/emqx_router_helper.erl 1 85.11%
src/emqx_broker.erl 4 81.44%
src/emqx_reason_codes.erl 10 90.71%
Totals Coverage Status
Change from base Build 3478520825: 0.01%
Covered Lines: 13779
Relevant Lines: 18293

💛 - Coveralls

@lafirest lafirest marked this pull request as ready for review November 18, 2022 07:24
@lafirest lafirest merged commit 06bbb17 into emqx:main-v4.3 Nov 21, 2022
@lafirest lafirest deleted the fix/ctl_atom_leak_v4.3 branch November 21, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants