Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMQX 7751 support message properties #9401

Merged

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Nov 21, 2022

Fixes EMQX-7751

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

changes/v5.0.11-zh.md Outdated Show resolved Hide resolved
@sstrigler sstrigler force-pushed the EMQX-7751-support-message-properties branch 2 times, most recently from 6241e3a to 895bd5a Compare November 22, 2022 14:45
@coveralls
Copy link
Collaborator

coveralls commented Nov 22, 2022

Pull Request Test Coverage Report for Build 3533708963

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • 35 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 78.108%

Files with Coverage Reduction New Missed Lines %
apps/emqx/src/emqx_cm.erl 1 90.83%
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 1 69.44%
apps/emqx/src/emqx_broker_helper.erl 1 90.7%
apps/emqx_authz/src/emqx_authz_schema.erl 1 90.28%
apps/emqx/src/emqx_channel.erl 2 87.23%
apps/emqx/src/emqx_flapping.erl 3 80.85%
apps/emqx_management/src/emqx_mgmt_cli.erl 5 27.43%
apps/emqx/src/emqx_sys_mon.erl 5 86.46%
apps/emqx/src/emqx_reason_codes.erl 16 86.03%
Totals Coverage Status
Change from base Build 3532949846: 0.02%
Covered Lines: 20961
Relevant Lines: 26836

💛 - Coveralls

@sstrigler sstrigler force-pushed the EMQX-7751-support-message-properties branch 2 times, most recently from d871c56 to ba1b700 Compare November 23, 2022 08:57
@zmstone zmstone closed this Nov 23, 2022
@zmstone zmstone reopened this Nov 23, 2022
zmstone
zmstone previously approved these changes Nov 23, 2022
changes/v5.0.11-en.md Outdated Show resolved Hide resolved
apps/emqx_management/src/emqx_mgmt_api_publish.erl Outdated Show resolved Hide resolved
apps/emqx_management/test/emqx_mgmt_api_publish_SUITE.erl Outdated Show resolved Hide resolved
changes/v5.0.11-zh.md Outdated Show resolved Hide resolved
@zmstone zmstone changed the base branch from master to release-v50 November 23, 2022 14:28
@zmstone zmstone dismissed their stale review November 23, 2022 14:28

The base branch was changed.

@zmstone zmstone changed the base branch from release-v50 to master November 23, 2022 14:30
@zmstone zmstone changed the base branch from master to release-v50 November 23, 2022 14:30
@zmstone
Copy link
Member

zmstone commented Nov 23, 2022

need a rebase to resolve conflicts for the release notes.

@sstrigler sstrigler force-pushed the EMQX-7751-support-message-properties branch from ba1b700 to af61af1 Compare November 23, 2022 16:02
@sstrigler sstrigler force-pushed the EMQX-7751-support-message-properties branch from af61af1 to afcb33a Compare November 23, 2022 16:04
@sstrigler sstrigler merged commit 08163fe into emqx:release-v50 Nov 24, 2022
@sstrigler sstrigler deleted the EMQX-7751-support-message-properties branch October 25, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants