feat: remove $queue in favor of $share #9412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Nov 23, 2022
|
rebase master |
olcai
force-pushed
the
remove-dollar-queue
branch
from
e9ce51e
to
9865d3a
Compare
olcai
force-pushed
the
remove-dollar-queue
branch
from
9865d3a
to
63e7157
Compare
This commit removes support for setting shared subscriptions with the non-standard $queue feature. Shared subscriptions is now part of the MQTT spec (using $shared) and we will only support that from now on.
filename:join/1 doesn't work on Windows for joining a topic. We now use emqx_topic:join/1 instead.
olcai
force-pushed
the
remove-dollar-queue
branch
from
63e7157
to
65398cf
Compare
|
changelog has been added - translation needed |
Pull Request Test Coverage Report for Build 3563683696
💛 - Coveralls |
zmstone
reviewed
Nov 28, 2022
olcai
changed the title
olcai
changed the title
Co-authored-by: Zaiming (Stone) Shi <zmstone@gmail.com>
zmstone
approved these changes
Nov 28, 2022
|
呃！$queue被删除，5.0 文档需要应该更新下，我昨天排查这个问题排查了好久 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for setting shared subscriptions with the non-standard $queue feature. Shared subscriptions is now part of the MQTT spec (using $share) and we will only support that from now on.
Fixes EMQX-8010.
PR to docs repo: emqx/emqx-docs#1510
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dirappupfiles updated (executescripts/update-appup.sh emqx)Backward Compatibility
More information