Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use PUT on /position to move authenticator #9419

Merged

Conversation

sstrigler
Copy link
Contributor

@sstrigler sstrigler commented Nov 24, 2022

Fixes EMQX-7863

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section
  • Sync with dashboard team on changes

Backward Compatibility

More information

savonarola
savonarola previously approved these changes Nov 25, 2022
@sstrigler sstrigler force-pushed the EMQX-7863-post-authentication-id branch 2 times, most recently from 1a06529 to 0d46bd5 Compare November 28, 2022 08:40
@sstrigler sstrigler changed the base branch from release-v50 to master November 28, 2022 08:40
changes/v5.0.12-zh.md Outdated Show resolved Hide resolved
@sstrigler sstrigler force-pushed the EMQX-7863-post-authentication-id branch from 0d46bd5 to c7f9dad Compare November 28, 2022 08:44
@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2022

Pull Request Test Coverage Report for Build 3576050827

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.04%) to 78.386%

Files with Coverage Reduction New Missed Lines %
apps/emqx/src/emqx_banned.erl 1 89.39%
apps/emqx/src/emqx_frame.erl 1 88.72%
apps/emqx/src/emqx_connection.erl 1 88.18%
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 73.04%
apps/emqx_gateway/src/exproto/emqx_exproto_gcli.erl 3 48.78%
apps/emqx/src/emqx_reason_codes.erl 14 88.97%
Totals Coverage Status
Change from base Build 3575053373: 0.04%
Covered Lines: 21031
Relevant Lines: 26830

💛 - Coveralls

@sstrigler sstrigler force-pushed the EMQX-7863-post-authentication-id branch from c7f9dad to a673c8b Compare November 28, 2022 09:57
@zmstone
Copy link
Member

zmstone commented Nov 29, 2022

need a rebase

@zmstone
Copy link
Member

zmstone commented Nov 29, 2022

will this affect dashboard?

@sstrigler
Copy link
Contributor Author

will this affect dashboard?

Yes, @ysfscream has been notified about changes

@sstrigler sstrigler force-pushed the EMQX-7863-post-authentication-id branch from a673c8b to b124e64 Compare November 29, 2022 16:29
@ysfscream
Copy link
Member

will this affect dashboard?

YES. @zmstone If it's merged. We will fix it immediately.

@sstrigler sstrigler changed the base branch from master to release-50 December 1, 2022 16:04
@sstrigler sstrigler changed the base branch from release-50 to master December 1, 2022 16:06
thalesmg
thalesmg previously approved these changes Dec 1, 2022
@sstrigler sstrigler changed the base branch from master to release-50 December 2, 2022 07:58
@sstrigler sstrigler dismissed thalesmg’s stale review December 2, 2022 07:58

The base branch was changed.

@sstrigler sstrigler merged commit 5b4feca into emqx:release-50 Dec 2, 2022
@sstrigler sstrigler deleted the EMQX-7863-post-authentication-id branch February 17, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants