New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use PUT on /position
to move authenticator
#9419
Merged
sstrigler
merged 1 commit into
emqx:release-50
from
sstrigler:EMQX-7863-post-authentication-id
Dec 2, 2022
Merged
refactor: use PUT on /position
to move authenticator
#9419
sstrigler
merged 1 commit into
emqx:release-50
from
sstrigler:EMQX-7863-post-authentication-id
Dec 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HJianBo
reviewed
Nov 25, 2022
savonarola
reviewed
Nov 25, 2022
savonarola
previously approved these changes
Nov 25, 2022
sstrigler
force-pushed
the
EMQX-7863-post-authentication-id
branch
2 times, most recently
from
November 28, 2022 08:40
1a06529
to
0d46bd5
Compare
sstrigler
commented
Nov 28, 2022
sstrigler
force-pushed
the
EMQX-7863-post-authentication-id
branch
from
November 28, 2022 08:44
0d46bd5
to
c7f9dad
Compare
Pull Request Test Coverage Report for Build 3576050827
💛 - Coveralls |
sstrigler
force-pushed
the
EMQX-7863-post-authentication-id
branch
from
November 28, 2022 09:57
c7f9dad
to
a673c8b
Compare
need a rebase |
will this affect dashboard? |
Yes, @ysfscream has been notified about changes |
sstrigler
force-pushed
the
EMQX-7863-post-authentication-id
branch
from
November 29, 2022 16:29
a673c8b
to
b124e64
Compare
YES. @zmstone If it's merged. We will fix it immediately. |
thalesmg
previously approved these changes
Dec 1, 2022
thalesmg
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-7863
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/
dirFor EMQX 4.x:appup
files updated (executescripts/update-appup.sh emqx
)If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow upIn case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility sectionBackward Compatibility
More information