fix: don't save cert/authz zip on disk when emqx start #9429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongwencool
force-pushed
the
dont-save-zip-on-disk
branch
from
cb7461e
to
5447c3f
Compare
zhongwencool
force-pushed
the
dont-save-zip-on-disk
branch
from
5447c3f
to
a24b4f4
Compare
zhongwencool
force-pushed
the
dont-save-zip-on-disk
branch
from
a24b4f4
to
64ab4ca
Compare
ieQu1
approved these changes
Dec 5, 2022
qzhuyan
reviewed
Dec 5, 2022
| {ok, []} -> | ||
| ?SLOG(debug, #{node => Node, msg => "sync_data_from_node_ignore"}); | ||
| {ok, Files} -> | ||
| ?SLOG(debug, #{node => Node, msg => "sync_data_from_node_ok", files => Files}) |
There was a problem hiding this comment.
do we need to handle the error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes <9402>
Make the data.zip file only in memory, don't need to save this on disk.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dirBackward Compatibility
More information